Refactor the add and remove methods in allies_controller.rb

[andrew-schutt]

Both of these methods are quite long (44 lines for add and 54 lines for the remove) it makes the methods difficult to read. rubocop has a default method length of 10 lines more information about this cop here

A good plan of attack for this issue would be the following:

1. Ensure that the tests for these two methods are complete and have full coverage
   1a. Tests can be found in the project directory structure at /spec/controllers/allies_controller_spec.rb
2. Begin extracting methods out from the two methods. Try to keep the new methods at about 10 lines in length.
   2a. Anywhere you see duplication or queries are good for extracting into separate methods
   2b. Extracted methods can be placed inside models, controllers, or new Ruby objects entirely
3. Rename variables capture query results that are being rerun (if possible)
4. Rerun tests, add new tests, refactor more!

relevant RailsCast episode

[julianguyen]

This is a great plan! Thanks for this 😄 Will you be working on this?

[andrew-schutt]

I sure will be! I was starting some work for #14 and realized that I need to this refactor in before.