Issue#2155 ux #2171
Issue#2155 ux #2171
Conversation
|
Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack. |
| @@ -97,6 +97,12 @@ | |||
| } | |||
|
|
|||
| &Desktop { | |||
| position: fixed; | |||
There was a problem hiding this comment.
With the header being fixed, you'll want to add some kind of margin-top value to the content of the page so that the header doesn't cover things. It should be height of the header + the existing margin or padding top value.
In addition, I think we should have a transparent background colour, I recommend using $black-80 or $black-90.
There was a problem hiding this comment.
Sure, I will be working on it! I will reach out via Slack even if I have questions.
saminarp
force-pushed
the
issue#2155-UX
branch
from
ff65920
to
f156ac8
Compare
|
Hello, I made a mistake force pushing the changes, please do not merge it. I will be creating a separate branch and push the updated PR |
|
Please refer to this PR and ignore the previous |
Description
With the following changes in
client/app/components/Header/Header.scss, the navbar will be sticky.More Details
The fixed navbar is not supported in mobile view. I intentionally left it out because the background is transparent in the navbar (i.e, background: transparent;) Giving the navbar a subtle color would prevent any clashes from occurring as a result of scrolling.
Corresponding Issue
This enhancement addresses the issue #2155.
Screenshots
Current behavior: navbar is in fixed position even with the scoll.
The screenshot below is the background color I would propose using but haven't implemented yet.
This would prevent the clashes with logo and content on the scroll
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!