Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible changes for v1.1.0 rc #14

Merged
merged 2 commits into from Aug 10, 2022
Merged

Conversation

ailzhang
Copy link
Contributor

@ailzhang ailzhang commented Aug 9, 2022

We're in the process of getting v1.1.0 release rc wheel and noticed this
PR is required for stannum to work v1.1.0.

v1.1.0 tracking: https://github.com/taichi-dev/taichi/milestone/5

Ailing Zhang and others added 2 commits August 9, 2022 22:31
We're in the process of getting v1.1.0 release rc wheel and noticed this
PR is required for stannum to work v1.1.0.
@ifsheldon
Copy link
Owner

I added a conditional import to not break the import when the users use Taichi < 1.1.0

BTW, can you link the corresponding Taichi issue?

@ailzhang
Copy link
Contributor Author

@ifsheldon We track v1.1.0 release in a milestone so I put it in the description as well.

Btw this change is not included in our release note in the sense that we don't expect taichi users to directly use classes from taichi._lib.core.taichi_python. For those public facing apis we currently maintain that in https://github.com/taichi-dev/taichi/blob/master/tests/python/test_api.py. But we do understand that as a library built on top of taichi, stannum actually depends on some taichi internals so we may plan to collect and properly expose those classes/types/utils as well. Wdyt?

@ifsheldon
Copy link
Owner

Yeah, I think so. I think at least Taichi types (scalar, vector, field types and ndarray and kernel types) can be public.

@ifsheldon ifsheldon merged commit 4039bf4 into ifsheldon:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants