Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganization of the apollon.tools #2

Open
Teagum opened this issue Apr 26, 2021 · 0 comments
Open

Reorganization of the apollon.tools #2

Teagum opened this issue Apr 26, 2021 · 0 comments
Assignees
Labels
refactor Code changes that do not affect behaviour

Comments

@Teagum
Copy link
Member

Teagum commented Apr 26, 2021

The tools module needs reorganization. Currently it includes function for statistics, IO, assertions, and array indexing. The idea of the tools module was to have a common place for functions that are shared between packages. As far as I can see, none of the functions in apollon.tools is used in more than one module. It is simply a mess.

As a first step, you have to check wether the functions in a apollon.tools are actually in use. fsum, for example, was part of a failed attempt to improve array sum accuracy. Unused functions shall be removed.

You then have to move each function to their corresponding module/package. For functions really could be used in different modules, check if it is worth the create a new module.

@Teagum Teagum added the refactor Code changes that do not affect behaviour label Apr 26, 2021
@Teagum Teagum self-assigned this Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code changes that do not affect behaviour
Projects
None yet
Development

No branches or pull requests

1 participant