Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify multiple value files #6

Open
milosgajdos opened this issue Oct 13, 2021 · 2 comments
Open

Allow to specify multiple value files #6

milosgajdos opened this issue Oct 13, 2021 · 2 comments

Comments

@milosgajdos
Copy link

Is your feature request related to a problem? Please describe.
Helm charts often contain multiple values files (usually to override default values with per-environment values) e.g.

  • values.yaml
  • values.test.yaml

Unfortunately, currently this action only provides support for a single values file not giving any choice to the usr to override the defaults with test values or whatnot

Describe the solution you'd like
I'd like to provide a list of value files so the action does something like this helm lint -f values.yaml -f values.foo.yaml .

Describe alternatives you've considered
There is no other alternative provided by helm I'm afraid -- at least not to my knowledge

Additional context

@imalik8088
Copy link

Perhaps an alternative, because I needed also to update my deps before doing the helm template command:

jobs:
  helm-check:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@master
    - name: Install Helm
      uses: azure/setup-helm@v1
      with:
        version: v3.5.1
    - name: helm-check-operator
      run: |
        cd ./operator
        helm dep up
        helm lint . --debug
        helm template -f values.yaml -f other-values.yaml . --debug

@igabaydulin
Copy link
Owner

igabaydulin commented Oct 15, 2021

There is CHART_VALUES environment variable which indeed allows to specify only one file with values. Probably we can make it work with multiple values files eg. separating it with ;:

env:
        CHART_LOCATION: ./helm-check-action-sample
        CHART_VALUES: ./helm-check-action-sample/values/test1.yaml;./helm-check-action-sample/values/test2.yaml

We just need to update entrypoint.sh and make it to parse CHART_VALUES variable. Currently I don't have time for this implementation, but you're welcome to create a pull request with this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants