-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug in parent #32
Comments
What do you mean by "mixed"? Do they appear to belong to a single country?
|
Yes, when I use the vue component, here's what happens:
I though this might be a bug in the vue component, bu the same behavior does not happen if the entire country DB is loaded at once, only when one country is loaded and then another is appended. |
Actually, even with the entire import I'm getting some strange results. /geo/ancestors/3469034 returns not only Brazilian states, but also those from Portugal and Poland. |
apparently there's something buggy in parent. |
Yep, definitely bugged. The PR #33 fixes |
Thanks for the PR... I will check this in the weekend and run some tests... The left/right columns are actually important to calculate the parents/children. This is a reference of how it works: Nested Set Model |
Hey, did you get a chance to look at this? |
Just to add some info and confirmation I am seeing a bug which sounds like it relates to this issue; I choose 'United Kingdom' and the top level dropdown is replace with Poland. I choose another such as Republic of Yemen and 3 dropdowns below pre-filled with unrelated places. |
@wrabit Check my for to see if fixes your bugs https://github.com/Corollarium/laravel_cities @igaster do you still plan to check this? If not please let me know and I'll make a separate package with my fork. |
@brunobg how can I pull in your version to my project? (tried setting up your repo in my composer.json and requiring it but no joy) |
@wrabit follow the composer instructions: https://getcomposer.org/doc/05-repositories.md#loading-a-package-from-a-vcs-repository If there's no response here I'll release my fork on composer. But I'm not using the tree, so I'd need to remove it from the code and it will take a bit of time that I don't have right now. Would you be up to give some help for that? It's essentially removing code. BTW, in my application I'm using the |
I ran these two commands:
When using the CityPicker states and cities mixed up, from individual US.txt and BR.txt. Importing the whole countries database did not result in this behavior. Is this something expected or a bug? Any workarounds?
The text was updated successfully, but these errors were encountered: