Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate panic!s for Result<T, E> #33

Closed
Scipi opened this issue Dec 31, 2020 · 1 comment
Closed

Deprecate panic!s for Result<T, E> #33

Scipi opened this issue Dec 31, 2020 · 1 comment

Comments

@Scipi
Copy link

Scipi commented Dec 31, 2020

The widespread use of .unwrap() and .expect() make this library unsuitable for use in applications that need to be fault-tolerant, such as webservers, etc. Consider refactoring code that can fail to use an Error type that encapsulates what went wrong so client code can decide how to handle the failure. If you'd like, I can make this change and submit a pull-request.
@Scipi Scipi mentioned this issue Dec 31, 2020
Closed
@mfreeborn mfreeborn mentioned this issue Sep 29, 2022
Open
47 tasks
@mfreeborn mfreeborn changed the title Depreciate panic!'s for Result<T, E> Deprecate panic!s for Result<T, E> Sep 29, 2022
@mfreeborn
Copy link
Contributor

Closing this as it is tracked in #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Scipi @mfreeborn