Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegisterAminoMsg panics when the message name is too long #3678

Closed
Ehsan-saradar opened this issue Oct 2, 2023 · 2 comments
Closed

RegisterAminoMsg panics when the message name is too long #3678

Ehsan-saradar opened this issue Oct 2, 2023 · 2 comments

Comments

@Ehsan-saradar
Copy link
Contributor

So apparently there's a hard limit in how long a Msg url/name can be when registering it with RegisterAminoMsg more on the issue on here
Now this raises an issue when we scaffold a chain with ignite with a long module name! Sure the name might not exceed the 39 character limit at first but when we add the module_name/Msg_name suffix later when scaffolding the Msgs it exceeds the char limit and running ignite chain serve will fails with a panic.

@julienrbrt
Copy link
Member

That's it true.

However we could (should ?) stop scaffolding Amino for new modules and new chains.

There is a new Cosmos app for Ledger that supports sign-mode textual, which would basically replace the last place where Amino was required.

The newest SDK modules (x/circuit, x/poolprotocol, x/accounts) do not support Amino for that reason.

@Pantani
Copy link
Collaborator

Pantani commented Oct 16, 2023

Closing in favor, this is an already known issue and is not on the Ignite side. And it will not happen in the next versions without Animo

@Pantani Pantani closed this as completed Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants