Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate additional security mechanism for module claim mission #28

Open
lumtis opened this issue Aug 26, 2022 · 0 comments
Open

Investigate additional security mechanism for module claim mission #28

lumtis opened this issue Aug 26, 2022 · 0 comments
Labels

Comments

@lumtis
Copy link
Contributor

lumtis commented Aug 26, 2022

We use right now hooks of modules and the CompleteMission interface to define the logic of claim mission:
Ex: Delegate hook of staking for the staking mission

Nothing prevent right now two modules to register the same mission ID for two different actions. We should explore on an additional mechanism to prevent two modules to register the same mission:
Example, somewhere in app.go

claimKeeper.setMissionAuthorization(
{
  1: staking.ModuleName
  2: gov.ModuleName
}
)
@lumtis lumtis added claim Claim module low priority labels Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant