Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previous archive page requested incorrectly. #284

Conversation

tairrzayev-chi
Copy link
Contributor

Unless I am mistaken, the previous archive page should be before the first message in the previous result set, not the last.

Previous page should be before the first message in the previous
result set, not the last.
@Flowdalic
Copy link
Member

Thank you for your contribution. This indeed does look like a bug. I've created SMACK-843 to track this. This also looks like a good candidate for the 4.3 branch.
Ideally this method would be part of the integration tests (or even better: the unit tests). In case you ever wanted to write a test for Smack. ;)

@Flowdalic Flowdalic self-assigned this Nov 21, 2018
@Flowdalic
Copy link
Member

Cherry picked onto 4.3 branch as 0332fa5

@Flowdalic Flowdalic closed this Nov 29, 2018
@bapihandzap
Copy link

After a fixed previous page issue now all messages in not receiving from mam query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants