Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indigo.design - Dialog window navigation did not work. #7

Closed
jennifershih opened this issue Nov 16, 2021 · 3 comments
Closed

Indigo.design - Dialog window navigation did not work. #7

jennifershih opened this issue Nov 16, 2021 · 3 comments
Assignees
Labels
bug Something isn't working ✅ status: resolved

Comments

@jennifershih
Copy link

I set up Dialog window, when I click logout, I expect it navigate to loginPage/login.
After code generation, when I run project, logout button didn't work.

1 screenshot-indigo design

<igx-dialog message="確定要登出?" leftButtonLabel="取消" rightButtonLabel="登出" [closeOnOutsideSelect]="true" [closeOnEscape]="true" (leftButtonSelect)="dialogWindow.toggle()" #dialogWindow class="dialog-window"><igx-dialog-title>登出</igx-dialog-title></igx-dialog
2 screenshot-gen_code

<igx-dialog message="確定要登出?" leftButtonLabel="取消" rightButtonLabel="登出" [closeOnOutsideSelect]="true" [closeOnEscape]="true" routerLink="/login-page/login" (leftButtonSelect)="dialogWindow.toggle()" #dialogWindow class="dialog-window"> <igx-dialog-title>登出</igx-dialog-title> </igx-dialog>
3 screenshot-run_project

@zdrawku
Copy link
Contributor

zdrawku commented Nov 16, 2021

@wnvko @Lipata it looks like the problem comes when when the "Navigate to" action is set to e child view part of another master view, for example, I've created a new master view "loginPage" with a child view "login".

image

And then upon setting the "Navigate to" action, I've noticed that the code view panel is not showing router link input

image

<igx-dialog message="Are you sure you want to do this?" leftButtonLabel="login" rightButtonLabel="close" [closeOnOutsideSelect]="true" [closeOnEscape]="true" #dialogWindow class="dialog-window">
	<igx-dialog-title>Confirmation</igx-dialog-title>
</igx-dialog>

If you set a "Navigate to" action to a child view part of the master view where the dialog is defined in, everything is working and generated well.

@wnvko wnvko added the bug Something isn't working label Nov 16, 2021
@wnvko
Copy link

wnvko commented Nov 16, 2021

This is a scenario which we are not handling now. I marked this as a bug.

@Lipata
Copy link
Member

Lipata commented Dec 21, 2021

@jennifershih this should be fixed now.

@Lipata Lipata closed this as completed Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ✅ status: resolved
Projects
None yet
Development

No branches or pull requests

4 participants