add exception on not set required array keys at getInvoicePayResultFr…

…omRequestArray method
igor-netFantom · Nov 27, 2023 · a7f89d8 · a7f89d8
1 parent 1332ffc
commit a7f89d8
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/RobokassaApi.php b/src/RobokassaApi.php
@@ -8,7 +8,10 @@
 
 use Http\Discovery\Psr18Client;
 use JsonException;
-use netFantom\RobokassaApi\Exceptions\{MissingRequestFactory, MissingStreamFactory, TooLongSmsMessageException};
+use netFantom\RobokassaApi\Exceptions\{InvalidArgumentException,
+    MissingRequestFactory,
+    MissingStreamFactory,
+    TooLongSmsMessageException};
 use netFantom\RobokassaApi\Options\{InvoiceOptions, ReceiptStatusOptions, SecondReceiptOptions};
 use netFantom\RobokassaApi\Params\Receipt\Vat;
 use netFantom\RobokassaApi\Results\{InvoicePayResult, ReceiptAttachResult, ReceiptStatusResult, SmsSendResult};
@@ -74,9 +77,13 @@ private function checkPsr18Client(): void
     public static function getInvoicePayResultFromRequestArray(array $requestParameters): InvoicePayResult
     {
         return new InvoicePayResult(
-            outSum: $requestParameters['OutSum'],
+            outSum: $requestParameters['OutSum'] ?? throw new InvalidArgumentException(
+            'OutSum request parameter required'
+        ),
             invId: isset($requestParameters['InvId']) ? (int)$requestParameters['InvId'] : null,
-            signatureValue: $requestParameters['SignatureValue'],
+            signatureValue: $requestParameters['SignatureValue'] ?? throw new InvalidArgumentException(
+            'SignatureValue request parameter required'
+        ),
             userParameters: self::getUserParametersFromRequestArray($requestParameters),
         );
     }