Fails to build due to illegal conversion between _Complex double and float

[marcusmueller]

using F34, cmake 3.20.5, clang 12.0.1 to build 878c4f7 against GNU Radio v3.9.4.0-40-g823f73013 :

FAILED: lib/CMakeFiles/gnuradio-dvbs2rx.dir/pl_freq_sync.cc.o
ccache /usr/bin/clang++ -DGR_MPLIB_GMP -Dgnuradio_dvbs2rx_EXPORTS -I../lib/../include -isystem /home/marcus/usrlocal-3.9/include -isystem /usr/include/python3.9 -march=native -Wall -O2 -g -DNDEBUG -fPIC   -fvisibility=hidden -std=gnu++17 -MD -MT lib/CMakeFiles/gnuradio-dvbs2rx.dir/pl_freq_sync.cc.o -MF lib/CMakeFiles/gnuradio-dvbs2rx.dir/pl_freq_sync.cc.o.d -o lib/CMakeFiles/gnuradio-dvbs2rx.dir/pl_freq_sync.cc.o -c ../lib/pl_freq_sync.cc
../lib/pl_freq_sync.cc:88:37: error: implicit conversion from '_Complex double' to 'float' is not permitted in C++
        unmod_pilots[i] = (+SQRT2_2 - SQRT2_2i);
                        ~  ~~~~~~~~~^~~~~~~~~~
1 error generated.

[marcusmueller]

everywhere like here, where it's clear the target type is gr_complex==std::complex<float>, you could do things like

unmod_pilots[i] = {+SQRT2_2, -SQRT2_2};

instead, to call the std::complex constructor via initialization list.

But this is done in a lot of places, and I'm not sure that trick works everywhere.

[igorauad]

Your solution in 8ee89fd has been merged to master already. Many thanks!