Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Other settings should be based on app.core.config settings #8

Closed
igorbenav opened this issue Oct 16, 2023 · 1 comment
Closed

Other settings should be based on app.core.config settings #8

igorbenav opened this issue Oct 16, 2023 · 1 comment
Assignees
@igorbenav
Labels
enhancement New feature or request

Comments

@igorbenav
Copy link
Owner

Ex: if settings inherits from RedisCacheSettings, create_redis_cache_pool() and close_redis_cache_pool() should be added to startup and shutdown respectively in create_application
@igorbenav igorbenav self-assigned this Oct 16, 2023
@igorbenav igorbenav added the enhancement New feature or request label Oct 16, 2023
@igorbenav
Copy link
Owner Author

closed with #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorbenav igorbenav

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igorbenav