Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How exactly do you build this? #7

Closed
asusralis opened this issue Sep 4, 2020 · 10 comments
Closed

How exactly do you build this? #7

asusralis opened this issue Sep 4, 2020 · 10 comments
Assignees

Comments

@asusralis
Copy link

I'm trying to use this into Unity. The .dll from nuget threw errors, so I was going to try and build it myself. However, building has many errors including not being to find ISourceIndexerPropertyTracer, ICanProcessSourceItemKeyChange, ICanProcessSourceItemValueChange... Where are these supposed to be located at?

@IgorBuchelnikov
Copy link
Owner

The current repository version is unstable (I'm working on v.2.0).
Stable versions are in NuGet packages only.
What version of the NuGet package do you use?
What error do you encounter?
Please, provide some code.

@IgorBuchelnikov IgorBuchelnikov self-assigned this Sep 7, 2020
@IgorBuchelnikov
Copy link
Owner

IgorBuchelnikov commented Sep 8, 2020

If you want to build, check out the revision whose comment contains the version of the NuGet package you are using. That revision also contains documentation that is relevant to the NuGet package.

For example, if you use v1.4.0:

Revision id: af0e50f

Url to download sources for v.1.4.0: https://github.com/IgorBuchelnikov/ObservableComputations/archive/af0e50ffa7376b160ae8fb3c0b9c1709779fb961.zip

Url to view repository of v1.4.0: https://github.com/IgorBuchelnikov/ObservableComputations/tree/af0e50ffa7376b160ae8fb3c0b9c1709779fb961

@asusralis
Copy link
Author

Thank you for the help! I was able to build it from the link you sent, and Unity gave no problems.

@IgorBuchelnikov
Copy link
Owner

IgorBuchelnikov commented Sep 11, 2020

Please let me know how you fixed the build issue. I want to fix future NuGet packages.

@asusralis
Copy link
Author

Fixed it for Unity? I just built the project you sent and used the .net standard 2.0 output. The build from the nuget, if I remember correctly, wouldn't load because of a missing dependency or something.

@IgorBuchelnikov
Copy link
Owner

Can you please put here the build log from the NuGet?

@asusralis
Copy link
Author

Sorry, I didn't see this. I can shortly ) I've been loving this library, by the way; super useful with Noesis GUI!

@asusralis
Copy link
Author

I get this:

Unloading broken assembly Assets/Plugins/ObservableComputations/ObservableComputations.dll, this assembly can cause crashes in the runtime

Error: Could not load signature of ObservableComputations.Ordering`2[TSourceItem,TOrderingValue]:get_SortDirectionScalar due to: Could not resolve type with token 01000044 (from typeref, class/assembly System.ComponentModel.ListSortDirection, System.ComponentModel.TypeConverter, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a) assembly:System.ComponentModel.TypeConverter, Version=4.2.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a type:System.ComponentModel.ListSortDirection member:(null) signature:

@IgorBuchelnikov
Copy link
Owner

IgorBuchelnikov commented Sep 27, 2020

Thank you for response! I cannot reproduce the error on my machine, so your additional help is needed.
Please execute in your app following code:

Assembly assembly = AppDomain.CurrentDomain.GetAssemblies().Single(a =>a.FullName.Contains("System.ComponentModel.TypeConverter"));

Console.WriteLine(assembly.CodeBase);
Console.WriteLine(assembly.FullName);
TypeInfo typeInfo = assembly.DefinedTypes.SingleOrDefault(t => t.Name.Contains("ListSortDirection"));
if (typeInfo != null)
    Console.WriteLine(typeInfo.AssemblyQualifiedName);

Send me output and System.ComponentModel.TypeConverter.dll assembly located in the directory pointed by "assembly.CodeBase"

@IgorBuchelnikov
Copy link
Owner

There is no response from the issue opener for a long time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants