Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with loading several categories #5

Closed
laurie-tonon opened this issue May 23, 2019 · 2 comments
Closed

Problem with loading several categories #5

laurie-tonon opened this issue May 23, 2019 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@laurie-tonon
Copy link

In our work we often want to test our gene lists against several categories of gene sets at once.
Until now we would load the gene sets like this:

msigdb.genes.sets <-msigdbr(species="Homo sapiens", category=c("H","C2"))

We noticed that in doing so, the gene sets are truncated, with a remaining number of genes in a gene set varying with the number of categories or their order.
After looking at the R code it seems the problem is that the categories are filtered with an "==" and not a "%in%, which means we cannot use an array in our command. But no warning or error is thrown and everything downstream works, with background ratio values wrong obviously.

Would it be possible to correct this or to forbid requesting more than one category in the command?

@igordot
Copy link
Owner

igordot commented May 23, 2019

Thank you for pointing this out. I did not expect multiple categories to be requested, but that scenario should definitely be handled better.

@igordot igordot added bug Something isn't working enhancement New feature or request labels May 23, 2019
@igordot
Copy link
Owner

igordot commented Sep 4, 2019

I disabled the ability to request more than one category/subcategory in the latest release, which is now on CRAN.

You can still use dplyr::filter() or dplyr::bind_rows() to combine any subsets.

@igordot igordot closed this as completed Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants