Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon support for button widget #84

Closed
therealtobo opened this issue Mar 12, 2016 · 8 comments
Closed

Icon support for button widget #84

therealtobo opened this issue Mar 12, 2016 · 8 comments
Milestone

Comments

@therealtobo
Copy link

It would be nice to be able to set an icon for the button widget. I've tried icon="garage" without any luck for example, is it supposed to be working already or future enhancement?

@arch1v1st
Copy link

Please share a snippet of your sitemap entries, 'icon' is working for me!

@therealtobo
Copy link
Author

Two examples below, maybe I was a bit hasty and this FR only applies for button-on/off and not the "regular" button?

Frame label="{widget:button-on}" icon="window" {
Frame label="{widget:button-off}" icon="garage" {

@therealtobo
Copy link
Author

@igorgladkov

Also, I'm guessing that maybe this should be closed, on/off buttons should be removed in the future and this ticket would sort that instead? Makes for a more flexible solution :)

#86

@igorgladkov
Copy link
Owner

@therealtobo Can you explain the use case you have that you using buttons for? It seems to me that this looks more like a switch

@therealtobo
Copy link
Author

Well, for the garage for example it only sends an "on" command on the KNX bus and that toggles the door. There is no up/down or similar. So, every time i push this button I want it to send a 1 on that KNX GA.

@therealtobo
Copy link
Author

Have you had a chance to look at this? Right now the button works but looks very dull since I can't select an icon for it.

@igorgladkov igorgladkov added this to the 0.14 milestone Jul 11, 2016
@igorgladkov
Copy link
Owner

Added in 0.14

@therealtobo
Copy link
Author

Works, thanks @igorgladkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants