Fix complex cases in no-unnecessary-duplication #22

igorkamyshev · 2021-08-30T04:55:04Z

fixes #21

github-actions · 2021-08-30T06:59:38Z

Total Coverage: 95.09%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
rules
rules/enforce-effect-naming-convention
enforce-effect-naming-convention.js	86.36%	100%	93.48%	35, 36, 72, 73, 96, 97
rules/enforce-store-naming-convention
enforce-store-naming-convention.js	86.67%	100%	93.10%	122, 123, 72, 73, 92, 93, 98, 99
rules/no-getState
no-getState.js	92.86%	100%	96.30%	32, 33
rules/no-unnecessary-duplication
no-unnecessary-duplication.js	100%	100%	100%

github-actions · 2021-08-30T14:43:55Z

Total Coverage: 95.09%

Coverage Report

File	Branch	Funcs	Lines	Uncovered Lines
rules
rules/enforce-effect-naming-convention
enforce-effect-naming-convention.js	86.36%	100%	93.48%	35, 36, 72, 73, 96, 97
rules/enforce-store-naming-convention
enforce-store-naming-convention.js	86.67%	100%	93.10%	122, 123, 72, 73, 92, 93, 98, 99
rules/no-getState
no-getState.js	92.86%	100%	96.30%	32, 33
rules/no-unnecessary-duplication
no-unnecessary-duplication.js	100%	100%	100%

igorkamyshev added 4 commits August 30, 2021 11:54

Add test for cases from issue #21

26142e5

Use text representation of node for comparing

26a4154

Add test case with complex formatting

9747c29

Use same formatting for text node comparing

18dca36

Merge branch 'master' into fix-bug-in-no-unnecessary-duplication

3eaced1

igorkamyshev marked this pull request as ready for review August 30, 2021 14:43

igorkamyshev merged commit 315a486 into master Aug 30, 2021

igorkamyshev deleted the fix-bug-in-no-unnecessary-duplication branch August 30, 2021 14:44

Provide feedback