Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: prefer-sample-over-forward-with-mapping #34

Merged
merged 4 commits into from Sep 3, 2021
Merged

Rule: prefer-sample-over-forward-with-mapping #34

merged 4 commits into from Sep 3, 2021

Conversation

igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented Sep 2, 2021 •
edited

Fixes #7

  • add suggestions

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Total Coverage: 94.68%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.48% 35, 36, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 94.83% 100, 123, 124, 72, 73, 99
rules/no-getState
   no-getState.js 91.67% 100% 95.83% 32, 33
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.29% 33, 34, 49, 50, 67, 68

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

Total Coverage: 94.68%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.48% 35, 36, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 94.83% 100, 123, 124, 72, 73, 99
rules/no-getState
   no-getState.js 91.67% 100% 95.83% 32, 33
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.29% 33, 34, 49, 50, 67, 68

@igorkamyshev
Copy link
Member Author

Suggestion is too complex in these cases. Won't be created.

@igorkamyshev igorkamyshev marked this pull request as ready for review September 3, 2021 05:47
@igorkamyshev igorkamyshev merged commit a2ad98c into master Sep 3, 2021
@igorkamyshev igorkamyshev deleted the prefer-sample-over-forward-with-mapping branch September 3, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule: prefer-sample-over-forward-with-mapping
1 participant
@igorkamyshev