Allow to use booleans in FetchApiRecord

igorkamyshev · Apr 3, 2023 · 8bf8b77 · 8bf8b77
1 parent ab5c118
commit 8bf8b77
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 4 deletions.
diff --git a/.changeset/wild-wolves-pull.md b/.changeset/wild-wolves-pull.md
@@ -0,0 +1,5 @@
+---
+'@farfetched/core': patch
+---
+
+Allow to use booleans in FetchApiRecord
diff --git a/packages/core/project.json b/packages/core/project.json
@@ -71,7 +71,7 @@
     "size": {
       "executor": "./tools/executors/size-limit:size-limit",
       "options": {
-        "limit": "18.3 kB",
+        "limit": "18.4 kB",
         "outputPath": "dist/packages/core"
       },
       "dependsOn": [

diff --git a/packages/core/src/fetch/lib.ts b/packages/core/src/fetch/lib.ts
@@ -1,4 +1,7 @@
-export type FetchApiRecord = Record<string, string | string[] | number>;
+export type FetchApiRecord = Record<
+  string,
+  string | string[] | number | boolean
+>;
 
 export function mergeRecords(
   ...records: (FetchApiRecord | undefined | null)[]
@@ -96,8 +99,10 @@ function recordToUrlSearchParams(record: FetchApiRecord): URLSearchParams {
   return params;
 }
 
-function clearValue(value: string | string[] | number): string | string[] {
-  if (typeof value === 'number') {
+function clearValue(
+  value: string | string[] | number | boolean
+): string | string[] {
+  if (typeof value === 'number' || typeof value === 'boolean') {
     return value.toString();
   }
 

diff --git a/packages/core/src/query/__tests__/create_json_query.query.test-d.ts b/packages/core/src/query/__tests__/create_json_query.query.test-d.ts
@@ -3,6 +3,8 @@ import { describe, test } from 'vitest';
 import { createJsonQuery } from '../create_json_query';
 import { Contract } from '../../contract/type';
 import { createStore } from 'effector';
+import { declareParams } from '../../remote_operation/params';
+import { unknownContract } from '../../contract/unknown_contract';
 
 describe('createJsonQuery query', () => {
   const response = {
@@ -35,4 +37,23 @@ describe('createJsonQuery query', () => {
       response,
     });
   });
+
+  test('supports boolean field in params', () => {
+    const query = createJsonQuery({
+      params: declareParams<{
+        id: string;
+        from: number;
+        to: number;
+        monthly: boolean;
+      }>(),
+      request: {
+        url,
+        method: 'GET',
+        query: ({ from, to, monthly }) => ({ from, to, monthly }),
+      },
+      response: {
+        contract: unknownContract,
+      },
+    });
+  });
 });