Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for non-16 bit WAV assets #78

Closed
igorski opened this issue Nov 11, 2018 · 3 comments
Closed

Add support for non-16 bit WAV assets #78

igorski opened this issue Nov 11, 2018 · 3 comments
Assignees
@igorski
Labels
improvement Enhancing existing functionality

Comments

@igorski
Copy link
Owner

igorski commented Nov 11, 2018

Loading .WAV files from the APK's packaged assets currently only supports 16-bit WAV files, support should be extended for any bit rate.
@teotigraphix
Copy link
Contributor

teotigraphix commented Nov 11, 2018 •
edited

Are you looking to write your own wav parsing code? Or OS code/library and then implement?

@igorski
Copy link
Owner Author

igorski commented Nov 12, 2018

WAVs are parsed by the engine already (apart from the header its all raw PCM values that can easily be processed), there is an oversight where the block size is assumed at 16-bits instead of deriving this from the bit rate defined in the header (which ironically, is read).

@igorski igorski self-assigned this Nov 13, 2018
@igorski igorski added the improvement Enhancing existing functionality label Dec 21, 2018
@igorski
Copy link
Owner Author

igorski commented Mar 24, 2019

Addressed in #96

@igorski igorski closed this as completed Mar 24, 2019
@YogarajRamesh YogarajRamesh mentioned this issue May 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igorski igorski

Labels
improvement Enhancing existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teotigraphix @igorski