Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventEmitterTrait::off #56

Closed
shuchkin opened this issue Jun 2, 2018 · 2 comments
Closed

EventEmitterTrait::off #56

shuchkin opened this issue Jun 2, 2018 · 2 comments

Comments

@shuchkin
Copy link

shuchkin commented Jun 2, 2018

public function off($event, callable $listener = null)

there logical error


public function off($event, callable $listener = null)
    {
        if ($listener === null) {
            return $this->removeListener($event, $listener);
        }
        return $this->removeAllListeners($event);
}

must be

public function off($event, callable $listener = null)
    {
        if ($listener !== null) {
            return $this->removeListener($event, $listener);
        }
        return $this->removeAllListeners($event);
}
@WyriHaximus
Copy link
Collaborator

Solved this, thank you for reporting

@shuchkin
Copy link
Author

shuchkin commented Aug 9, 2018

np

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants