Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout_kamada_kawai() maxiter should scale with graph size #627

Closed
szhorvat opened this issue Jan 12, 2023 · 1 comment
Closed

layout_kamada_kawai() maxiter should scale with graph size #627

szhorvat opened this issue Jan 12, 2023 · 1 comment

Comments

@szhorvat
Copy link
Member

layout_kamada_kawai() uses maxiter=1000 by default. The recommendation in the C core docs is:

 * \param maxiter The maximum number of iterations to perform. A reasonable
 *        default value is at least ten (or more) times the number of
 *        vertices.

The Mathematica and R interfaces both use 50*vcount.

The Python interface should also use a maxiter value that at least scales with the vertex count.

@ntamas
Copy link
Member

ntamas commented Jan 12, 2023

Fixed this, see above; tests are failing on my machine, but it seems to be unrelated (they failed even without this change). I'll continue investigating tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants