Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: New vignette("deprecated-dot-case") that lists deprecated functions and their alternatives #1013

Merged
merged 5 commits into from Dec 25, 2023
Merged

docs: New vignette("deprecated-dot-case") that lists deprecated functions and their alternatives #1013

merged 5 commits into from Dec 25, 2023

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Dec 18, 2023

Draft as long as the main build isn't fixed. Locally it's knit without any issue 馃槆

@krlmlr this is the article we had discussed.

@maelle maelle requested a review from krlmlr December 18, 2023 12:44
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Dec 18, 2023 •
edited

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr
Copy link
Contributor

krlmlr commented Dec 18, 2023

dplyr needed too: https://github.com/igraph/rigraph/actions/runs/7248241585/job/19743772732?pr=1013#step:6:806

@krlmlr krlmlr changed the title docs: add article about deprecated functions docs: New vignette("deprecated-dot-case") that lists deprecated functions and their alternatives Dec 18, 2023
krlmlr
krlmlr reviewed Dec 18, 2023
View reviewed changes
Copy link
Contributor

@krlmlr krlmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'd prefer if the harvesting step would be carried out only once, storing a plain text file (CSV/JSON) in this repo.

@maelle
Copy link
Contributor Author

maelle commented Dec 19, 2023

That's indeed a much better idea 馃槄

@krlmlr
Copy link
Contributor

krlmlr commented Dec 21, 2023

Is this ready to go?

@aviator-app aviator-app bot removed the mergequeue label Dec 21, 2023
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Dec 21, 2023

This pull request can't be queued because it's currently a draft.

@maelle maelle marked this pull request as ready for review December 21, 2023 15:42
@krlmlr
Copy link
Contributor

krlmlr commented Dec 25, 2023

Thanks!

@aviator-app aviator-app bot merged commit 323f1b4 into igraph:main Dec 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krlmlr krlmlr krlmlr left review comments

Assignees
No one assigned
Labels
mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maelle @krlmlr