refactor: clean up some auto-generation code #1031
Conversation
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
aviator-app
bot
force-pushed
the
refactor/interface-cleanup-1-b
branch
from
6469a16
to
463d43a
Compare
|
This pull request failed to merge: some CI status(es) failed. Remove the Failed CI(s): codecov/patch |
| @@ -297,7 +297,7 @@ VERTEXSET_LIST: | |||
|
|
|||
| VERTEXSETLIST_INT: | |||
| INCONV: | |||
| IN: '%I% <- lapply(%I%, function(x) as.integer(x)-1L)' | |||
| IN: '%I% <- lapply(%I%, function(x) as.numeric(x)-1)' | |||
There was a problem hiding this comment.
This looks like a bug fix?
There was a problem hiding this comment.
This was a mistake on my part. VERTEXSETLIST_INT is unused and should be completely removed.
| @@ -258,11 +258,11 @@ EDGE_COLOR: | |||
| } | |||
| } | |||
| if (!is.null(%I%)) { | |||
| %I% <- as.integer(%I%)-1L | |||
| %I% <- as.numeric(%I%)-1 | |||
There was a problem hiding this comment.
This looks like a bug fix?
There was a problem hiding this comment.
Yes it is. R_SEXP_to_vector_int_copy() should expect a real, not an integer.
There was a problem hiding this comment.
Here's a test for this:
count_isomorphisms(make_ring(3), make_ring(3), edge.color1=c(2,2,2), edge.color2=c(2,2,2), vertex.color1=c(3,3,3), vertex.color2=c(3,3,3), method='vf2')
This crashed before this fix. Could you please help me by adding this to the test suite?
There was a problem hiding this comment.
Never mind, it was easy enough. See #1050
|
This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts). |
krlmlr
force-pushed
the
refactor/interface-cleanup-1-b
branch
from
463d43a
to
7f2372b
Compare
From #1026.