chore!: Hard-deprecate as_adjacency_matrix(edges = )
#1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
krlmlr
force-pushed
the
f-851-as-adj-edges
branch
from
37f3c28
to
36fa375
Compare
|
@maelle: This also affects |
|
See the failing tests with this PR. |
maelle
reviewed
Jan 8, 2024
This was referenced Jan 8, 2024
maelle
force-pushed
the
f-851-as-adj-edges
branch
from
32a53e1
to
b7f8bb6
Compare
maelle
changed the title
as_adjacency_matrix(edges = )as_adjacency_matrix(edges = )
|
krlmlr
commented
Jan 20, 2024
| if (!sparse) { | ||
| get.adjacency.dense(graph, type = type, attr = attr, weights = NULL, names = names) | ||
| } else { | ||
| if (sparse) { | ||
| get.adjacency.sparse(graph, type = type, attr = attr, edges = edges, names = names) |
There was a problem hiding this comment.
Passing edges now looks like dead code, but get.adjacency.sparse() will be implemented in C anyway, perhaps no need to act.
Comment on lines
+320
to
321
| #' @param edges `r lifecycle::badge("deprecated")` Logical scalar, whether to return the edge ids in the matrix. | ||
| #' For non-existant edges zero is returned. |
There was a problem hiding this comment.
Should we just mention that this must be omitted?
| if (!missing(edges)) { | ||
| warning("The `edges` argument of `as_adjacency_matrix` is deprecated; it will be removed in igraph 1.4.0") | ||
| if (!missing(edges) && isTRUE(edges)) { | ||
| lifecycle::deprecate_stop("2.0.0", "as_adjacency_matrix(edges = )") | ||
| } |
There was a problem hiding this comment.
Add a deprecate_soft() if edges is FALSE ?
krlmlr
force-pushed
the
f-851-as-adj-edges
branch
2 times, most recently
from
59ad321
to
c85c8f0
Compare
|
revdepchecks look fine. |
aviator-app
bot
force-pushed
the
f-851-as-adj-edges
branch
from
c85c8f0
to
89a1d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #815.