Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sample_pa() respects the out.seq and out.dist arguments again, regression introduced in igraph 2.0.0 #1226

Merged
merged 3 commits into from Feb 9, 2024

Conversation

szhorvat
Copy link
Member

@szhorvat szhorvat commented Feb 8, 2024

Closes #1224.

@krlmlr Let's hope CI passes. Can you please help with adding a test? While this is a stochastic function, sample_pa(3, out.seq=0:2) should always output the same thing as make_full_citation_graph(3)

Copy link
Contributor

aviator-app bot commented Feb 8, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr added this to the phoenix 🔥 milestone Feb 9, 2024
@krlmlr krlmlr changed the title fix: sample_pa() completely ignored the contents of the out.seq vector, fixes #1224 fix: sample_pa() respects the out.seq and out.dist arguments again, regression introduced in igraph 2.0.0 Feb 9, 2024
@krlmlr
Copy link
Contributor

krlmlr commented Feb 9, 2024

Thanks for taking this on!

@szhorvat
Copy link
Member Author

szhorvat commented Feb 9, 2024

Would this work as a test?

identical_graphs(sample_pa(3, out.seq=0:2), make_full_citation_graph(3))

I forgot about identical_graphs(). This is a stronger test than what we already have.

@krlmlr
Copy link
Contributor

krlmlr commented Feb 9, 2024

We'd want expect_identical_graphs() for this to be idiomatic. In the next iteration.

@aviator-app aviator-app bot merged commit 3994f2b into main Feb 9, 2024
25 checks passed
@aviator-app aviator-app bot deleted the fix/sample_pa-1224 branch February 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample_pa() fails to add edges
2 participants