Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add skip condition for rglplot test #1306

Merged
merged 1 commit into from Mar 22, 2024

Conversation

mfansler
Copy link
Contributor

@mfansler mfansler commented Mar 13, 2024

The rgl package is a Suggests dependency. As such, testing of functions depending on rgl should skip if it is not installed. This PR adds such a skip condition.

Test failures due to lack of skip condition were encountered during Conda Forge builds of v2.0.3.

Copy link
Contributor

aviator-app bot commented Mar 13, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr changed the title Add skip condition for rglplot test test: Add skip condition for rglplot test Mar 21, 2024
@krlmlr
Copy link
Contributor

krlmlr commented Mar 21, 2024

Thanks!

@aviator-app aviator-app bot added the blocked label Mar 21, 2024
Copy link
Contributor

aviator-app bot commented Mar 21, 2024

This pull request failed to merge: PR cannot be automatically rebased, please rebase manually to continue. Remove the blocked label to re-queue.

Additional debug info: Failed to rebase this PR onto the latest changes from the base branch. You will probably need to rebase this PR manually and resolve conflicts).

Copy link
Contributor

aviator-app bot commented Mar 21, 2024

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Check ubuntu-20.04 (oldrel-1), Check ubuntu-20.04 (oldrel-4), Check ubuntu-20.04 (oldrel-2)

@aviator-app aviator-app bot added the blocked label Mar 21, 2024
@maelle maelle removed the blocked label Mar 22, 2024
@aviator-app aviator-app bot merged commit 607d64a into igraph:main Mar 22, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants