New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample_forestfire() tests and example 🔥 #1318
Conversation
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
Can we have a 🌳 as well in the title in addition to 🔥? 🤭 |
@szhorvat it seems we can't 😭 I hope you can review the PR regardless of the title 😁 No hurry though |
I am on it, just got distracted by something else in the meantime. The 🌳 was just a joke :-) |
I know it was a joke but I still wanted to improve the title!! such a disappointment that one cannot add more than one emoji. |
I think the current example is valuable because it shows the heavy tailed degree distribution, which is mentioned in the docs. Even the warning is valuable as it indicates what's missing from the plot. Is there any way to keep the example? Is it going to interfere with the CI tests? |
b0c59a9
to
af58f60
Compare
Thanks @maelle for all these improvements! :-) It's great to see how much momentum we gained since you came aboard! |
Fix #1292