Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample_forestfire() tests and example 🔥 #1318

Merged
merged 2 commits into from Mar 26, 2024
Merged

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Mar 25, 2024

Fix #1292

  • test: refactor sample_forestfire() tests to make them smaller and more self-contained
  • docs: simplify example to not have to deal with log of 0

@maelle maelle requested a review from szhorvat March 25, 2024 13:27
Copy link
Contributor

aviator-app bot commented Mar 25, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat
Copy link
Member

Can we have a 🌳 as well in the title in addition to 🔥? 🤭

R/games.R Show resolved Hide resolved
@maelle maelle changed the title sample_forestfire() tests and example 🔥 sample_forestfire() tests and example 🌳 🌲 🌳 🔥 Mar 25, 2024
@maelle maelle changed the title sample_forestfire() tests and example 🌳 🌲 🌳 🔥 sample_forestfire() tests and example 🔥 Mar 25, 2024
@maelle
Copy link
Contributor Author

maelle commented Mar 25, 2024

@szhorvat it seems we can't 😭 I hope you can review the PR regardless of the title 😁 No hurry though

@szhorvat
Copy link
Member

I am on it, just got distracted by something else in the meantime. The 🌳 was just a joke :-)

@maelle
Copy link
Contributor Author

maelle commented Mar 25, 2024

I know it was a joke but I still wanted to improve the title!! such a disappointment that one cannot add more than one emoji.

@szhorvat
Copy link
Member

I think the current example is valuable because it shows the heavy tailed degree distribution, which is mentioned in the docs. Even the warning is valuable as it indicates what's missing from the plot. Is there any way to keep the example? Is it going to interfere with the CI tests?

@aviator-app aviator-app bot merged commit 8609d6b into main Mar 26, 2024
14 checks passed
@aviator-app aviator-app bot deleted the example-warning branch March 26, 2024 13:22
@szhorvat
Copy link
Member

Thanks @maelle for all these improvements! :-) It's great to see how much momentum we gained since you came aboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning in sample_forestfire() example
2 participants