refactor: add assert_named_list() helper to assert the value is a named list with no duplicate names #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This PR was merged using Aviator.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
maelle
commented
Mar 26, 2024
| @@ -349,10 +349,7 @@ graph.attributes <- function(graph) { | |||
| #' @export | |||
| "graph.attributes<-" <- function(graph, value) { | |||
| ensure_igraph(graph) | |||
| if (!is.list(value) || (length(value) > 0 && is.null(names(value))) || | |||
There was a problem hiding this comment.
I don't see why value would have no length, but I added the case.
There was a problem hiding this comment.
well it does happen according to what happened in tests before I accounted for the case
|
I'll go ahead and merge to continue my reading/refactoring journey of this script (before I can tackle #1303!) |
…ed list with no duplicate names
aviator-app
bot
force-pushed
the
assertlist
branch
from
92c3d92
to
1481863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1321