refactor!: Remove igraph.eigen.default() and eigen_defaults, introduce internal eigen_defaults() as a function
#741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_defaults() as a function
maelle
commented
Mar 30, 2023
| @@ -321,8 +321,6 @@ deprecated("hub.score", hub_score) | |||
| deprecated("igraph.arpack.default", arpack_defaults) | |||
| #' @export igraph.console | |||
| deprecated("igraph.console", console) | |||
| #' @export igraph.eigen.default | |||
There was a problem hiding this comment.
it's problematic that this was exported. I'm not sure it was used though?!
Codecov Report
@@ Coverage Diff @@
## main #741 +/- ##
==========================================
- Coverage 53.93% 53.92% -0.01%
==========================================
Files 357 357
Lines 73282 73284 +2
==========================================
- Hits 39526 39522 -4
- Misses 33756 33762 +6
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Doesn't seem to be used: https://github.com/search?q=org%3Acran%20igraph.eigen.default&type=code |
krlmlr
changed the title
igraph.eigen.default() and eigen_defaults, introduce internal eigen_defaults() as a function
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy case from the two lists in #714