Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: as_long_data_frame() now correctly processes vertex attributes and works with graphs without vertex attributes #748

Merged
merged 3 commits into from Mar 31, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Mar 31, 2023

Closes #297.

@krlmlr krlmlr changed the title fix: as_long_data_frame() now works with named and unnamed graphs. fix: as_long_data_frame() now correctly processes vertex attributes and works with graphs without vertex attributes Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #748 (a37b83a) into main (57fc160) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head a37b83a differs from pull request most recent head 5d47802. Consider uploading reports for the commit 5d47802 to get more accurate results

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   53.82%   53.82%   -0.01%     
==========================================
  Files         358      358              
  Lines       73092    73092              
==========================================
- Hits        39343    39342       -1     
- Misses      33749    33750       +1     
Impacted Files Coverage Δ
R/conversion.R 74.27% <100.00%> (+0.36%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@krlmlr krlmlr merged commit c5f7194 into main Mar 31, 2023
11 checks passed
@krlmlr krlmlr deleted the b-297-long branch March 31, 2023 14:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

as_long_data_frame() fails or has bad column names
1 participant