Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Merge tests #822

Merged
merged 3 commits into from Jun 5, 2023
Merged

test: Merge tests #822

merged 3 commits into from Jun 5, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented May 27, 2023

@ntamas: The tests now fail. Do the make sense to you at all?

@ntamas
Copy link
Member

ntamas commented May 27, 2023

No, it doesn't. The tests are correct; in particular, dyad census should give a warning with undirected graphs (and now it does not give a arning); also, running a dyad census on a large empty graph should print an overflow warning because there are N*(N-1) empty dyads in an empty graph if the graph has N vertices. If the warnings are not printed, then this is incorrect behaviour.

@ntamas
Copy link
Member

ntamas commented Jun 5, 2023

Okay, now it's correct. dyad_census() was changed somewhere between igraph 0.9 and 0.10 so it indicates overflow by returning -1 so that's why the change is needed in the unit test.

@krlmlr krlmlr merged commit bb86f49 into main Jun 5, 2023
11 checks passed
@krlmlr krlmlr deleted the f-dyad-census branch June 5, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants