Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rename arguments to assortativity(values, values.in) from types1 and types2 #952

Merged
merged 1 commit into from Nov 11, 2023

Conversation

krlmlr
Copy link
Contributor

@krlmlr krlmlr commented Nov 10, 2023

No description provided.

Copy link
Contributor

aviator-app bot commented Nov 10, 2023

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.


See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@krlmlr krlmlr requested a review from szhorvat November 10, 2023 19:25
@krlmlr
Copy link
Contributor Author

krlmlr commented Nov 10, 2023

This is the last interface incompatibility introduced in the igraph-0.10 branch, as far as I can tell. Merging it here to decouple interface changes from library updates.

@szhorvat: Please confirm that this is intended.

@szhorvat
Copy link
Member

Yes, intended.

@krlmlr
Copy link
Contributor Author

krlmlr commented Nov 10, 2023

assortativity_nominal() still has types, should we update that too?

@szhorvat
Copy link
Member

assortativity_nominal() still has types, should we update that too?

No, because those are actually types, i.e. it's a categorical variable.

@aviator-app aviator-app bot merged commit 3593dba into main Nov 11, 2023
13 checks passed
@aviator-app aviator-app bot deleted the f-assortativity-interface branch November 11, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants