Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shortcut to 'restore' original speed (1x) #33

Closed
ElijahLynn opened this issue Apr 2, 2015 · 8 comments
Closed

New shortcut to 'restore' original speed (1x) #33

ElijahLynn opened this issue Apr 2, 2015 · 8 comments

Comments

@ElijahLynn
Copy link
Contributor

I use this extension quite a bit to watch slow motion replays of baseball. After I have replayed the desired section in slow mode I always want to restore the speed, which requires me to press multiple times to get back to 1x. Would a PR be accepted to add a keyboard shortcut for the "r" key to restore to a hardcoded 1x speed?

@ElijahLynn ElijahLynn reopened this Apr 2, 2015
@igrigorik
Copy link
Owner

Yep, seems reasonable :)

@truth1ness
Copy link

+1, definitely would like to see this.

I'm curious, why "r", though? "f" seems to make more sense as it's in line with the others and easy to lay one finger on each. Even "w" or "e" would make more sense since you usually keep your three left fingers on the three current keys so these would be a more natural slide up. Personally I think "W" makes the most sense. A S D W is an extremely common key mapping from games to some audio/video applications/etc.

@ElijahLynn
Copy link
Contributor Author

I am neutral, just thought R was convenient and it could stand for 'reset' or 'restore'. R appeared to be free and F on my box (Ubuntu) is already reserved in YouTube for fullscreen allthough not sure if that is something custom I setup or not.

Does F affect your YouTube experience?

@truth1ness
Copy link

Ah. Yes, F is reserved for fullscreen. W is free for me though.

@hsingh23
Copy link

loads of peoples use vimium here https://vimium.github.io/

@cocomonk22
Copy link

I also believe there should be a key to reset to 1.0 speed. R would be good since it is close to the existing shortcut keys.

@igrigorik
Copy link
Owner

Added reset functionality in 42c3578. Please give it a try -- you'll have to load it as an "unpacked extension".

@ElijahLynn
Copy link
Contributor Author

Tested, works great, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants