Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Story TEXT and AUDIO types #5

Open
emmanuel-D opened this issue Sep 29, 2021 · 2 comments
Open

Support for Story TEXT and AUDIO types #5

emmanuel-D opened this issue Sep 29, 2021 · 2 comments

Comments

@emmanuel-D
Copy link

Hello 馃憢 ,
I am currently using your Library and it's behaves very well. The animations are pretty good.

But there are some limitations for customization.
For example it would be nice being able to display TEXT stories. There is already an existing type named text for that in your code. (react-native-stories-media/src/index.d.ts:9).

Moreover it will also be nice to have the ability to pass customs types like audio. So this way we should probably add some props to the <Stories/> component to render Stories with those customs types: For example: renderTextStory, renderAudioStory.

At the end, the Stories component could look like this:

<Stories
  data={data}
  renderTextStory={...}
  renderAudioStory={...}
/>

I could also contribute to implement this if you want 馃槈 .

@emmanuel-D
Copy link
Author

Hey @iguilhermeluis 馃憢馃徑,
Are you planning to maintain this library or are your currently working on this issues ?

Thanks for answering

@iguilhermeluis
Copy link
Owner

Hello @emmanuel-D, sorry for the delay, I'm planning yes! Great suggestion, I thought it was amazing, let's code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants