Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Options, File to Save, Mouse-operated keyboard window, there is a graphic default on the up arrow of the "Shift" button #7895

Closed
1 task done
LeHerosInconnu opened this issue Oct 7, 2023 · 4 comments
Labels
improvement New feature, request or improvement ui UI/GUI related stuff

Comments

@LeHerosInconnu
Copy link

Preliminary checks

Describe the problem requiring a solution

In fheroes2, there is a graphic default on the up arrow of the "Shift" button.

In fheroes2:

Mouse keyboard 01

Default at the bottom of the graphic, at the vertical part of the upward-pointing arrow:
Mouse keyboard  Maj key default 01

Describe the possible solution

Correct the default.

Additional info

No response

@LeHerosInconnu LeHerosInconnu added the improvement New feature, request or improvement label Oct 7, 2023
@LeHerosInconnu LeHerosInconnu changed the title File Options, File to Save, Mouse-operated keyboard window, here is a graphic default on the up arrow of the "Shift" button File Options, File to Save, Mouse-operated keyboard window, there is a graphic default on the up arrow of the "Shift" button Oct 7, 2023
@oleg-derevenetz oleg-derevenetz added the ui UI/GUI related stuff label Oct 7, 2023
@oleg-derevenetz oleg-derevenetz added this to the Beyond OG scope milestone Oct 7, 2023
@ihhub
Copy link
Owner

ihhub commented Oct 7, 2023

Hi @LeHerosInconnu , what exactly is wrong with the button? Please point precisely the place which has an issue.

@oleg-derevenetz
Copy link
Collaborator

oleg-derevenetz commented Oct 7, 2023

This is a sort of a "Caps Lock" icon, and not the regular arrow:

caps-lock-icon-29

And it is perfectly justified, because this button is "sticky", just like the Caps Lock button on the physical keyboard.

@LeHerosInconnu
Copy link
Author

Hello @ihhub,

Hi @LeHerosInconnu , what exactly is wrong with the button? Please point precisely the place which has an issue.

The arrow seems to be "cut" at the bottom, in a way that adds nothing visually, except that it is perceived as a display fault.

Even if the current representation could be valid, the sprite definition in fheroes2 doesn't allow the display to emerge clearly or correctly.
In that case, we might as well use a standard, well-known representation, which doesn't pose any problems for the display due to the sprite definition in fheroes2.

Here's an example of the standard representation:

Other examples shown in a famous search engine:

https://www.google.com/search?q=shift+key&tbm=isch&ved=2ahUKEwiByubzoeSBAxWhtycCHWIODXYQ2-cCegQIABAA&oq=shift+key&gs_lcp=CgNpbWcQARgAMgUIABCABDIFCAAQgAQyBQgAEIAEMgUIABCABDIFCAAQgAQyBQgAEIAEMgUIABCABDIECAAQHjIECAAQHjIECAAQHjoHCAAQigUQQzoICAAQsQMQgwE6CAgAEIAEELEDOgsIABCABBCxAxCDAToKCAAQigUQsQMQQ1DSDVjPOmCrTGgAcAB4AIABVogB1gWSAQIxMJgBAKABAaoBC2d3cy13aXotaW1nwAEB&sclient=img&ei=9XohZcH7MqHvnsEP4py0sAc&bih=1028&biw=1920

@ihhub
Copy link
Owner

ihhub commented Apr 13, 2024

I am closing this issue as per @oleg-derevenetz explanation why we chose this icon for the button.

@ihhub ihhub closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature, request or improvement ui UI/GUI related stuff
Projects
None yet
Development

No branches or pull requests

3 participants