Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap addresses function not appropriete #33

Closed
PaulMelloy opened this issue Dec 17, 2020 · 4 comments
Closed

Wrap addresses function not appropriete #33

PaulMelloy opened this issue Dec 17, 2020 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@PaulMelloy
Copy link
Collaborator

Just want to document and discuss dropping the function wrap_address.

I can't see the use for this function in spore dispersal models ever. Correct me if I am wrong, but the function seems to: if an infection coordinate is generated outside the paddock dimensions to takes the x or y coordinate and moderates it. for example

If the paddock dimensions are 100m x 100m and the grid is 1x1m
and a coordinate is generated of c(50,105) the function "wraps" this address so the output is c(50,5)

I am in favour of if a coordinate is generated which is outside the study area the coordinates are dropped. Therefore I suggest removing this function.

@PaulMelloy PaulMelloy added the documentation Improvements or additions to documentation label Dec 17, 2020
@IhsanKhaliq
Copy link
Owner

Isn't the wrapping option simulate spread outside the paddock? See a piece from Art's paper, '
The spore dispersal vectors are considered to originate from the center of the subunit of origin. The spores land in whatever subunit contains the termination point of the vector. The destination subunit may be the same subunit from which a spore has originated, or it may be another subunit within or outside the field. When the destination subunit is located outside the field, the model can be set to either of two options, to ignore it or to wrap it.
When wrapping is chosen, the model simulates the equivalent of an infinite area made up of repeated copies of the field. When wrapping is not chosen, the model simulates a finite area isolated
from other sources of disease'

@adamhsparks
Copy link
Collaborator

adamhsparks commented Dec 17, 2020 via email

@IhsanKhaliq
Copy link
Owner

@PaulMelloy could you please confirm that wrapping option has been removed from the model, so I can delete the relevant text from the manuscript?

@PaulMelloy
Copy link
Collaborator Author

Yes wrapping has been removed from the model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants