Parameters missing from the model

[IhsanKhaliq]

https://github.com/IhsanKhaliq/Ascotracer/blob/d241125729ce383ec56f3a9ff8b69f3deb3789c4/R/trace_asco.R#L48-L61

Table 3 of Art paper lists parameters used in the model. When I look at the tras_asco function it has the following parameters missing
Distance due to rain splash
Distance due to wind
Spore deposition
Rainfall threshold
Potentially infective spore pro
The duration for which when a new growing point is susceptible
Base temperature for spore growth

There are many additional parameters in trace_asco function, but I guess there is nothing wrong with the additional parameters. But we should add missing parameters.
I can add them if you like.

[IhsanKhaliq]

Missing parameters

1. Distance due to rain splash
2. Distance due to wind
3. Spore deposition
4. Rainfall threshold
5. Potentially infective spore pro
6. The duration for which when a new growing point is susceptible
7. Base temperature for spore growth

[PaulMelloy]

I have not finished adding parameters, these will likely be in the parameters when I am done

[IhsanKhaliq]

I can add them if you like.

[PaulMelloy]

If you could add sporesPerInfectiveGPPerWetHour which needs to be passed down to the potentially_infective_spores function
For now that would be good, I'll start review the need to add others.
Ones like 6. "The duration for which when a new growing point is susceptible" are already in there

[IhsanKhaliq]

By definition, it would be the number of spores per infective grouping point (lesion) in a wet hour. It's value is 0.15 in the model script - the low value is counter intuitive (it should be in thousands), so I searched the entire model script. Turns out that it's been defined, but not being used in the functions. I searched both Art and Diggle papers, it's not there either. I think this is redundant like many others that have been defined but not actually used. By the way sporesPerInfectiveGPPerWetHour is not listed in the table of parameters listed above.

[PaulMelloy]

I beleive the parameter is variable dependant on the cultivar and is the value Spi
The Diggle paper give 3 possible values, 0.25, 0.43 or 3.70 to each respective cultivar Wonga , Myallie and Kiev Mutant.
The 0.15 value is what is given in the Mathematica code, this might be a parameter that needs consideration for the Chickpea varieties.

[IhsanKhaliq]

That would be spore rate. I have written in the methods - taken from Coventry.

[IhsanKhaliq]

[PaulMelloy]

What value did they find fit the observed data best?

[IhsanKhaliq]

0.220. It's in the table of the thesis chapter I shared

[PaulMelloy]

spore_rate is spores_per_gp_per_wet_hour and is set at 0.22 as default but can be changed by the user.
See e73445b

[IhsanKhaliq]

Added