Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross origin requests #1

Merged
merged 2 commits into from Apr 2, 2014
Merged

Allow cross origin requests #1

merged 2 commits into from Apr 2, 2014

Conversation

AsafGartner
Copy link
Contributor

Allows us to make api requests from other domains

Allows us to make api requests from other domains
@ifeins
Copy link
Member

ifeins commented Apr 2, 2014

Looks ok, a few things:

  • Extract the method implementation to CorsSupport, leave the after_filter :allow_cross_origin line in application_controller.rb.
  • Have you tested it in any way? You can define a host for it locally in /etc/hosts: local.lunchtime.com and then in localhost make a cross origin post request.

ifeins added a commit that referenced this pull request Apr 2, 2014
@ifeins ifeins merged commit 6dfae32 into master Apr 2, 2014
@ifeins ifeins deleted the cross_origin branch May 21, 2014 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants