Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinning versions of requirements #90

Closed
digitaldogsbody opened this issue Oct 21, 2022 · 0 comments · Fixed by #91
Closed

Pinning versions of requirements #90

digitaldogsbody opened this issue Oct 21, 2022 · 0 comments · Fixed by #91

Comments

@digitaldogsbody
Copy link
Member

Tox has started showing a deprecation warning for part of pydantic:

./home/mike/projects/iiif-prezi3/iiif_prezi3/base.py:35: DeprecationWarning: copy_on_model_validation should be a string: 'deep', 'shallow' or 'none'

However, changing this value to any from the list caused test failures. It turns out tox is installing the requirements each run in a temporary virtual environment, and thus was installing a newer version of Pydantic than my local virtualenv.

This leads to test inconsistencies etc and I think is best resolved by pinning dependency versions in setup.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant