Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #318: Locating an Item in Place and Time #113

Open
glenrobson opened this issue May 4, 2023 · 3 comments
Open

Recipe #318: Locating an Item in Place and Time #113

glenrobson opened this issue May 4, 2023 · 3 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This recipe demonstrates how navPlace and navDate can be used together to locate an item both in time and place. This recipe uses as an example a collection of manifests which have navPlace and navDate and these are shown in a custom viewer to show what is possible.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@glenrobson glenrobson added this to the May 2023 milestone May 4, 2023
@thehabes
Copy link

thehabes commented May 14, 2023

@mikeapp looks good, I appreciate having all the JSON examples. I found a classic "please capitalize"

The navDate property, as implied by its name, allows a manifest to identify

This instance of manifest should be capitalized to Manifest.

I will also note that the Navplace Viewer would render the Collection. I will let you decide how you feel about the warning that the Collection does not have the navPlace Extension context.json

@mikeapp
Copy link
Member

mikeapp commented May 15, 2023

I don't think the navPlace context should be required at the Collection level in this case. I can adjust the language about Manifest.

@glenrobson
Copy link
Member Author

Issue 113 (Recipe #318: Locating an Item in Place and Time )

+1: 22 [akrishnan15 cubap danieltbrennan dlpierce eliotjordan glenrobson hadro ioanrichards irv jpadfield jtweed julsraemy kirschbombe markpatton markpbaggett mikeapp nfreire regisrob robcast thehabes tpendragon triplingual]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 0 []

Result: 22 / 22 = 1.00

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants