Merge pull request #2712 from stps/subtitle-border

Fix subtitle border width option in quick settings
iina · Jan 12, 2020 · 9af7362 · 9af7362
2 parents b65dff7 + cdc9fb7
commit 9af7362
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/iina/QuickSettingViewController.swift b/iina/QuickSettingViewController.swift
@@ -707,10 +707,8 @@ class QuickSettingViewController: NSViewController, NSTableViewDataSource, NSTab
   }
 
   @IBAction func subTextSizeAction(_ sender: AnyObject) {
-    if let selectedItem = subTextSizePopUp.selectedItem {
-      if let value = Double(selectedItem.title) {
-        player.setSubTextSize(value)
-      }
+    if let selectedItem = subTextSizePopUp.selectedItem, let value = Double(selectedItem.title) {
+      player.setSubTextSize(value)
     }
   }
 
@@ -719,7 +717,7 @@ class QuickSettingViewController: NSViewController, NSTableViewDataSource, NSTab
   }
 
   @IBAction func subTextBorderWidthAction(_ sender: AnyObject) {
-    if let value = Double(subTextBorderWidthPopUp.stringValue) {
+    if let selectedItem = subTextBorderWidthPopUp.selectedItem, let value = Double(selectedItem.title) {
       player.setSubTextBorderSize(value)
     }
   }