Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide main window when entering PiP #2147

Closed
1 task done
CourierKyn opened this issue Dec 28, 2018 · 5 comments
Closed
1 task done

Hide main window when entering PiP #2147

CourierKyn opened this issue Dec 28, 2018 · 5 comments

Comments

@CourierKyn
Copy link

CourierKyn commented Dec 28, 2018

System and IINA version:

  • macOS 10.14.2 (18C54)
  • IINA 1.0.0-rc

Expected behavior:
When entering Picture in Picture mode, the former IINA window should hide immediately, leaving only the PiP visible. That's just like how it works in iTunes.

Actual behavior:
When entering Picture in Picture mode, the main IINA window remains visible, together with the PiP.

Steps to reproduce:
N/A

  • MPV does not have this problem.

How often does this happen?
N/A

@CourierKyn CourierKyn changed the title Hide main windows when entering PiP Hide main window when entering PiP Dec 29, 2018
@anohren
Copy link
Contributor

anohren commented Jan 2, 2019

Highly disagree. For those interested, the reasons for this can be found in this discussion: #2128

Edit: except of course in the case that the window is not in fullscreen. There's a case to be made for hiding it then.

The downsides I can see with doing that is that you will not have access to any controls (except PiP's play/pause) unless you exit PiP again. If you e.g. want to skip the credits for every episode you're watching you'll have to do a lot of context switching just to gain access to the keyboard shortcuts or the playlist panel.

Edit 2: After thinking about it some more, actually finding the existing window is probably at least as much effort as just exiting PiP, so that might not be a downside after all. I'm for it as long as it excludes fullscreen windows.

@CourierKyn
Copy link
Author

I appreciate your support very much.

@dhoepfl
Copy link

dhoepfl commented Jan 2, 2019

I agree with the request.

Having a normal window telling me that there is a PIP window is like having a normal window telling me that the content is presented in fullscreen. Who would do that?

@soya-daizu
Copy link
Contributor

soya-daizu commented Jan 3, 2019

I personally also appreciate this.
Sometimes I just wanted to use PiP to simply reduce all the scattered windows, and this feature can make that possible. However, I'm pretty sure some may not appreciate this change as well, therefore this can be optional.

@saagarjha
Copy link
Member

I think we've fixed this with #2192.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants