Fix various issue regarding window size in music mode #2771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, if there's no video track, mpv won't send the
video reconfig
event and thus windows won't change their sizes accordingly. Info such as aspect ratio and video size will remain to be the last video track. I'm not sure whether it worked well before and it's an internal change in mpv. Now the player remains functional due to an awkward fallback mechanism, and here are some obvious glitches:In this PR,
notifyMainWindowVideoSizeChanged
is also called onplayback restart
if there's no video track to make sure windows receive the resize event.player.originalVideoSize
is used to check if there's no video in the mini player. The default window size has been changed to 640x400.Before merging, extensive tests are required to ensure it didn't break anything.