Closes support Reduce motion preference, #3437 #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AccessiblityPreference struct containing methods that make it easy for other code to handle the Reduce motion preference. Modified methods in MainWindowController that support entering and exiting full screen mode and showing and hiding the side bar to suppress animations if Reduce motion has been enabled.
low-batt
changed the title
saagarjha
reviewed
Dec 12, 2021
iina/AccessibilityPreference.swift
Outdated
|
|
||
| import Foundation | ||
|
|
||
| struct AccessibilityPreference { |
There was a problem hiding this comment.
Suggested change
| struct AccessibilityPreference { | |
| struct AccessibilityPreferences { |
iina/AccessibilityPreference.swift
Outdated
| /// Adjusts an animation to be instantaneous if the macOS System Preference Reduce motion is enabled. | ||
| /// - Parameter duration: Desired animation duration. | ||
| /// - Returns: `0` if reduce motion is enabled; otherwise the given duration. | ||
| static func adjustDuration(_ duration: TimeInterval) -> TimeInterval { |
There was a problem hiding this comment.
Suggested change
| static func adjustDuration(_ duration: TimeInterval) -> TimeInterval { | |
| static func adjustedDuration(_ duration: TimeInterval) -> TimeInterval { |
iina/AccessibilityPreference.swift
Outdated
| /// check or uncheck Reduce motion. | ||
| /// | ||
| /// - Returns: `true` if reduce motion is enabled; otherwise `false`. | ||
| static func reduceMotion() -> Bool { |
There was a problem hiding this comment.
Suggested change
| static func reduceMotion() -> Bool { | |
| static var motionReductionEnabled: Bool { |
There was a problem hiding this comment.
Opps. Messed this one up. Missed the bit about switching to computed property. Will drink some coffee and will fix the fix.
There was a problem hiding this comment.
The 3rd commit addresses this review comment properly. Let me know if I need to be rebasing or squashing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added AccessiblityPreference struct containing methods that make it
easy for other code to handle the Reduce motion preference.
Modified methods in MainWindowController that support entering and
exiting full screen mode and showing and hiding the side bar to
suppress animations if Reduce motion has been enabled.
Description: