Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media keys doesn't work, #3574 #3579

Merged
merged 1 commit into from Apr 24, 2022
Merged

Conversation

low-batt
Copy link
Contributor

The commit in the pull request:

  • Adds the ability to set the state to NowPlayingInfoManager.updateInfo

  • Eliminates the method NowPlayingInfoManager.updateState

  • Changes PlayerCore.fileStarted to set the state to playing

  • Changes references to updateState to use updateInfo

  • This change has been discussed with the author.

  • It implements / fixes issue Media keys doesn't work #3574.


Description:

The commit in the pull request:
- Adds the ability to set the state to `NowPlayingInfoManager.updateInfo`
- Eliminates the method  `NowPlayingInfoManager.updateState`
- Changes  `PlayerCore.fileStarted` to set the state to `playing`
- Changes references to `updateState` to use `updateInfo`
@lhc70000 lhc70000 merged commit 856f3fd into iina:develop Apr 24, 2022
lhc70000 pushed a commit that referenced this pull request Apr 24, 2022
The commit in the pull request:
- Adds the ability to set the state to `NowPlayingInfoManager.updateInfo`
- Eliminates the method  `NowPlayingInfoManager.updateState`
- Changes  `PlayerCore.fileStarted` to set the state to `playing`
- Changes references to `updateState` to use `updateInfo`
@tueksta
Copy link

tueksta commented Feb 7, 2023

is this working for everybody? I'm on Monterey 12.6.3 and 1.3.1 Build 133 does not react to media keys at all.

@low-batt
Copy link
Contributor Author

low-batt commented Feb 7, 2023

Hi @tueksta,

I just tested IINA 1.3.1 on my MacBookPro18,2 under macOS Ventura 13.2 and media keys worked for me.

Try this:

  • Start IINA
  • Click on Settings… (preferences) under the IINA menu
  • The settings panel appears
  • On the left side of the panel click on Key Bindings
  • On the right side of the panel at the top is the setting Use system media control
  • Is this setting checked (enabled)?

This setting controls IINA's use of the media keys as well as use of the now playing widget in Control Center. If this setting is not checked, check it, restart IINA and test the media keys again.

If it is checked then we will need to dig into why this is not working.

@tueksta
Copy link

tueksta commented Feb 7, 2023

hmm, seems the service wasn't running after all. got fixed by launchctl load -w /System/Library/LaunchAgents/com.apple.rcd.plist thanks for the quick feedback though.

@low-batt
Copy link
Contributor Author

low-batt commented Feb 7, 2023

Yikes! Not what I expected. Definitely bring up Console and check crash reports to see if macOS background daemons are crashing and restarting.

Thanks for letting us know what was causing the failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants