Fix camera housing blocks controller, #3558 #3618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit in the pull request:
Extends NSScreen with a new optional computed property,
cameraHousingHeight
Changes MainWindowController.legacyAnimateToFullscreen to check if
cameraHousingHeight indicates a camera housing intrudes into the
screen and if so reduces the size of the full screen video window's
view's frame appropriately.
This change has been discussed with the author.
It implements / fixes issue Camera housing blocks onscreen controller #3558.
Description:
This PR replaces PR #3559 and takes a different approach addressing code review comments in the original PR.