Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlinks in recently opened files can cause duplicates in Welcome Window #3788

Closed
svobs opened this issue Jun 4, 2022 · 2 comments · Fixed by #3789
Closed

Symlinks in recently opened files can cause duplicates in Welcome Window #3788

svobs opened this issue Jun 4, 2022 · 2 comments · Fixed by #3789

Comments

@svobs
Copy link
Contributor

svobs commented Jun 4, 2022

System and IINA version:

  • macOS 12.4
  • IINA 1.3.0

IINA-InitialWindow-Screenshot

Steps to reproduce:

  1. In IINA Preferences > General, make sure "Enable playback history" and "Resume last playback position" are selected.
  2. In the terminal, copy a video into /tmp and change its permissions like this:
sudo cp myVideo.mp4 /tmp/myVideo.mp4
sudo chown `whoami` /tmp/myVideo.mp4

Then open it with IINA-cli:

/Applications/IINA.app/Contents/MacOS/iina-cli /tmp/myVideo.mp4

When it starts to play, quit IINA. Then open it again without a video file, so it displays the Welcome window.

Expected behavior:
Recent video appears first in the list with the option to "Resume"

Actual behavior:
Recent video appears first in the list with the option to "Resume", and again right below it.


Steps to reproduce:

How often does this happen?
Always for these paths.

@svobs
Copy link
Contributor Author

svobs commented Jun 4, 2022

Forgot to point out where the symlink comes in. In modern MacOS, /var and /tmp have been relocated under /private:

$ ls -l /tmp
lrwxr-xr-x@ 1 root  wheel  11 May  9 14:30 /tmp -> private/tmp

@low-batt
Copy link
Contributor

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants