Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reveal in Finder" should be renamed to "Show in Finder" #3976

Closed
svobs opened this issue Oct 10, 2022 · 7 comments · Fixed by #3982
Closed

"Reveal in Finder" should be renamed to "Show in Finder" #3976

svobs opened this issue Oct 10, 2022 · 7 comments · Fixed by #3982

Comments

@svobs
Copy link
Contributor

svobs commented Oct 10, 2022

System and IINA version:

  • macOS 12.6
  • IINA 1.3.0 Build 132

Not sure when it happened, but the standard English language label for this functionality appears to be "Show in Finder", not "Reveal in Finder". IINA should be updated to match.

Examples:

  1. Open Chrome. Go to "chrome://downloads/"
  2. Open a project in XCode. Right-click on a file in the Navigator.
  3. Right-click on any application in the Dock > Options > Show in Finder

Expected behavior:
Preferences > Key Bindings has a button labeled "Show config file in Finder".
File > Playback History -> (right-click on a row in Player History window) > context menu has an item labelled "Show in Finder"
Preferences > Plugins has a button labeled "Show in Finder"

Actual behavior:
Preferences > Key Bindings has a button labeled "Reveal config file in Finder"
File > Playback History -> (right-click on a row in Player History window) > context menu has an item labelled "Reveal in Finder"
Preferences > Plugins has a button labeled "Reveal in Finder"

@low-batt
Copy link
Contributor

Other actions in IINA that bring up a Finder window:

  • Go to Screenshot Folder in the Video menu
  • Open log directory in Advanced preferences

@uiryuu
Copy link
Member

uiryuu commented Oct 13, 2022

I'll try to make a fix. It might be complicated than just renaming the texts since I also want to rename the corresponding key (pl_menu.reveal_in_finder), and I'm not sure how Crowdin would handle such key change.

@uiryuu
Copy link
Member

uiryuu commented Oct 13, 2022

"alert.config.file_existing.message" = "This should not happen. Choose OK to overwrite, Cancel to reveal the file in Finder.";
Another "reveal" spotted.

@uiryuu
Copy link
Member

uiryuu commented Oct 13, 2022

image

This is in the OSD after a screenshot is taken. What do you guys think about this one? (I'm not a native English speaker)

@svobs
Copy link
Contributor Author

svobs commented Oct 13, 2022

This is in the OSD after a screenshot is taken. What do you guys think about this one? (I'm not a native English speaker)

My vote is to change to "Show" as well. It looks like another case of "Show in Finder" functionality, but due to the limited space and use of block character font it makes sense to shorten it to one word - to avoid ambiguity about the bounds of the button/link.

@svobs
Copy link
Contributor Author

svobs commented Oct 13, 2022

Slightly unrelated, but thought this was helpful: guidelines for the use of "Show" vs. "Reveal" vs "Indicate" in research papers:

"Show" is perhaps the plainest of the three. Use it when the statement obviously follows from the source...
...Use "reveal" to convey that it took some analysis or interpretation of the data to arrive at the conclusion.
"Indicate" is similar to "show" but introduces a note of uncertainty: that the data leads you to suspect something but you can't be sure.

Maybe Apple's original thought was that using "reveal" instead of "show" would help indicate that it would involve going outside the current application. But the word itself didn't lend anything to indicate that, other than being different; the user would have to learn that over time, and it wasn't a feature which had common enough use for that to be worthwhile.

@low-batt
Copy link
Contributor

low-batt commented Jan 2, 2024

This is fixed in the released version of IINA.

@low-batt low-batt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants